fix: use actual newline in E2E event parser buffer concatenation#714
Merged
fix: use actual newline in E2E event parser buffer concatenation#714
Conversation
The event parser was using "\\n" (literal backslash-n) to join split lines, which corrupted JSON when large events (like startRun with full instruction text) were split across multiple stdout lines. Changed to "\n" (actual newline) so JSON.parse can handle multi-line event output. Also removes temporary debug logging from E2E tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseEventsusing"\\n"(literal backslash-n, 2 chars) instead of"\n"(actual newline) when joining split lines in the bufferJSON.parseto fail on large events (likestartRunwith full instruction text) that were split across multiple stdout linesstartRunevent JSON grew after splitting InstructionMessage into multiple TextParts, making it more likely to exceed stdout buffer boundaries and get splitRoot cause
When a large JSON event line gets split across multiple lines in stdout, the parser buffers it. But
buffer += "\\n" + lineinserted literal\ncharacters (not actual newlines), producing invalid JSON like...text\nmore text...where the\nis two characters instead of a proper JSON escape sequence.Test plan
🤖 Generated with Claude Code